Don't use the deprecated fields in ToolchainCluster.Spec #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the register member tests to take the new version and workflows into account.
metlos
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19,
mfrancisc,
drpaneas and
fbm3307
as code owners
xcoulon
approved these changes
Oct 2, 2024
MatousJobanek
approved these changes
Oct 2, 2024
This was referenced Oct 2, 2024
Merged
…package and simplify the logic in the mocking functions slightly.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #84 +/- ##
==========================================
- Coverage 69.66% 69.57% -0.09%
==========================================
Files 43 43
Lines 2571 2564 -7
==========================================
- Hits 1791 1784 -7
Misses 589 589
Partials 191 191
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to the streamlined version of ToolchainCluster and fix the register member tests to take the new version and workflows into account.
Related PRs: